[Fixed - rebuilt] 3.62: game segfaults when finishing a hole that was resumed

[craftyguy]

OS: Arch Linux

When I resume digging a hole, once the hole is finished I get a message about finding some buried items and then the game segfaults. I have a save where this happens 100% of the time (just resume digging the hole immediately to the west), I can email it if you're interested in taking a look.

[Sami]

OS: Arch Linux

When I resume digging a hole, once the hole is finished I get a message about finding some buried items and then the game segfaults. I have a save where this happens 100% of the time (just resume digging the hole immediately to the west), I can email it if you're interested in taking a look.

Alright, send the save over and I'll take a look.

Can you still dig holes with one go (without resuming)?

[craftyguy]

Alright, send the save over and I'll take a look.

Can you still dig holes with one go (without resuming)?

not sure, my character isn't able to/I don't have a good shovel, so every attempt (no matter how rested) forces me to take a break about half way

[Sami]

Ok. I got the save and will experiment it asap. I'll reply back her ewhen I've found something to report.

[craftyguy]

Were you able to reproduce the crash with the save file I sent?

[Sami]

Were you able to reproduce the crash with the save file I sent?

No. It worked okay on my end, but I could test only with Windows and Ubuntu.
Tricky case, but I'll try to read the code carefully to see if there are vulnerabilities which might cause something like this.

[craftyguy]

No. It worked okay on my end, but I could test only with Windows and Ubuntu.
Tricky case, but I'll try to read the code carefully to see if there are vulnerabilities which might cause something like this.

Interesting, it reproduces every time for me. In case it's helpful, here's some more info about the SDL version installed:

sdl 1.2.15-13 
sdl2 2.0.12-1
sdl2_image 2.0.5-1 
sdl2_mixer 2.0.4-3   
sdl2_net 1:2.0.1-2
sdl2_ttf 2.0.15-1
sdl_image 1.2.12-5
sdl_mixer 1.2.12-7                                                                                                                                                                                                                                                                                                                                                                                                                     
sdl_net 1.2.8-4 
sdl_sound 1.0.3-7
sdl_ttf 2.0.11-5

I ran urw through gdb but since there are no symbols the backtrace from the segfault was useless. If there's a way you could get me a debug-compiled version of urw 3.62 to run, I could collect that info for you too.

[Sami]

This is really quite a mystery. I've tried it several times, but never fails here. I don't think it's about SDL. But also checking out the new shoveling code I couldn't find anything that might interfere.

You could try enabling debug logs (by pressing & key) and then reproduce and send all the debug_*.txt files in your game folder over to me.
& needs to be pressed after the character has loaded, and the game confirms "Enabled debug logs".

Also, can you dig a pit elsewhere?

[craftyguy]

This is really quite a mystery. I've tried it several times, but never fails here. I don't think it's about SDL. But also checking out the new shoveling code I couldn't find anything that might interfere.

You could try enabling debug logs (by pressing & key) and then reproduce and send all the debug_*.txt files in your game folder over to me.
& needs to be pressed after the character has loaded, and the game confirms "Enabled debug logs".

Also, can you dig a pit elsewhere?

I emailed you the logs, I hope that helps. I'm not able to dig a pit elsewhere successfully. Each time I resume, it segfaults after it finishes. I can try to steal a regular shovel and attempt to dig it in one go, or if you have a way I can add a shovel to my inventory to test that I could give that a try. It might at least tell us if the resume is the issue or not.

[Plotinus]

I'm having this problem, too with my character Tiera. Tiera has a regular shovel and the pit digging wasn't paused, I dug the pit all in one go, then it said that i found some items at the bottom of the pit and segfaulted. When I reloaded the game, there wasn't even a partial pit there. I tried digging pits in a few other places (within that tile and also in a different tile where i'd never been before).

 I'll enable debug logs and send them to you.

My character Seppo has this problem too.

[Sami]

This is fixed now and downloadable packages rebuilt.
Those who were suffering from the bug just re-download and re-install.

Fixed.